[rekonq] Re: Review Request: Adding the feature to Open with Preferred application and Open with options

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100164/#review388
-----------------------------------------------------------


The error pano reported depends on the code. Try using this:
static bool KRun::run (const KService &service, const KUrl::List &urls, QWidget *window, bool tempFiles=false, const QString &suggestedFileName=QString(), const QByteArray &asn=QByteArray());
So:
- No need to search for desktopEntryName(). You just have a KService. You don't need anything else.
- The second parameter is a KUrl::List. Please, use it also if you have just one.

- Andrea


On 2010-11-21 11:45:20, Chinmaya Padhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100164/
> -----------------------------------------------------------
> 
> (Updated 2010-11-21 11:45:20)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Adding the feature of Open with Preferred Application and Open With options , while clicked on a file . 
> 
> 
> Diffs
> -----
> 
>   src/webpage.cpp 2347b6d 
> 
> Diff: http://git.reviewboard.kde.org/r/100164/diff
> 
> 
> Testing
> -------
> 
> Tested on various files by clicking on them and opening them in the preferred application. It works fine .
> 
> 
> Thanks,
> 
> Chinmaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101121/e5811edd/attachment.htm