[rekonq] Re: Review Request: Text highlighting in the url bar simplified

[Jon Ander Peñalba]

> On 2010-11-17 11:08:40, Benjamin Poulain wrote:
> > I am not convinced by the patch, it looks like a side effect paradise.
> > For example what if there is two words like this: "foo( )bar", the regexp would not be what you expect. Not to mention all the control character of regexps: . * [ ] + ( ), etc

We could still replace all those symbols with a | like with spaces.


- Jon Ander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100154/#review351
-----------------------------------------------------------


On 2010-11-16 19:17:39, Jon Ander Peñalba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100154/
> -----------------------------------------------------------
> 
> (Updated 2010-11-16 19:17:39)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> I've simplified text highlighting. I think the behaviour hasn't changed, but a second opinion is welcome :)
> 
> I've removed the Qt::escape (and updated the test accordingly) because I find it useless, but if it needs to be there for any reason there's no problem in putting it back.
> 
> 
> Diffs
> -----
> 
>   src/tests/listitem_test.cpp fc0b62e 
>   src/urlbar/listitem.cpp a0462e7 
> 
> Diff: http://git.reviewboard.kde.org/r/100154/diff
> 
> 
> Testing
> -------
> 
> The 'listitem_test' test passes.
> 
> 
> Thanks,
> 
> Jon Ander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101117/37e7f59c/attachment.htm