[rekonq] Re: Review Request: Icon for add opensearch engine

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100064/#review338
-----------------------------------------------------------


I tested it again and it seems working well. What I could not understand is:
- where are all the info saved from the dialog?
- why does it continue to appear also if I just have a shourtcut for that engine?

Another thing. I checked your branch from your clone and I read your commit logs: "fix this", "add that", etc... Can you pls squash them?
Last, you have 3 different names in your commit sign :)

- Andrea


On 2010-11-07 17:30:01, Lionel Chauvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100064/
> -----------------------------------------------------------
> 
> (Updated 2010-11-07 17:30:01)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Icon at the right of the urlbar that allows to add an opensearch engine (it needs more work but it is a good start)
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f0310b4 
>   src/opensearch/suggestionparser.cpp 98bb8a6 
>   src/urlbar/listitem.h f5f1153 
>   src/urlbar/listitem.cpp 5fa4647 
>   src/urlbar/urlbar.h 67a693c 
>   src/urlbar/urlbar.cpp 1f4a036 
>   src/urlbar/webshortcutwidget.h PRE-CREATION 
>   src/urlbar/webshortcutwidget.cpp PRE-CREATION 
>   src/webtab.h 3fd4f79 
>   src/webtab.cpp 0a55060 
> 
> Diff: http://git.reviewboard.kde.org/r/100064/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lionel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101114/f0953f0a/attachment.htm