[rekonq] Re: Review Request: Added a visit count parameter to the history. This will used expecially in the Awesome UrlBar ordering suggestions code.

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100147/#review336
-----------------------------------------------------------



src/history/historymanager.h
<http://git.reviewboard.kde.org/r/100147/#comment280>

    Watch out, trailing space! ;)



src/history/historymanager.cpp
<http://git.reviewboard.kde.org/r/100147/#comment281>

    couldn't we keep the same history and read the visitCount field only if (ver >= 24) ?


- Pierre


On 2010-11-14 17:10:12, Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100147/
> -----------------------------------------------------------
> 
> (Updated 2010-11-14 17:10:12)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added a visit count parameter to the history. This will used expecially in the Awesome UrlBar ordering suggestions code.
> 
> It costs us a change in the HISTORY_VERSION and a temporary use of a new history file (called "history2")
> So, it needs further testing
> 
> 
> Diffs
> -----
> 
>   src/history/historymanager.h 1e03fb1c9dceb6388de0b121b7f46feb255cc3ea 
>   src/history/historymanager.cpp 92f9caeea905f6c0bb21b28c19e4364a62cef0a3 
>   src/history/historymodels.h d193cf860e25da1b650dd3b37d406e65f1511df0 
>   src/history/historymodels.cpp 793ff7e50dfb2eef97f84480dd5113fb3752f88a 
> 
> Diff: http://git.reviewboard.kde.org/r/100147/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101114/7d5545c8/attachment.htm