[rekonq] Re: Review Request: Print && Find actions for the parts :)

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100143/#review333
-----------------------------------------------------------


Style: a few missing space between if and the following parenthesis.


src/findbar.cpp
<http://git.reviewboard.kde.org/r/100143/#comment279>

    I don't get the intent there. Maybe a comment would help.


I don't know enough about KPart to review this properly. Could you detail a bit more what you are doing in the commit message?
I would also split the patch since there are some very unrelated things going on there.

- Benjamin


On 2010-11-10 23:48:24, Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100143/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 23:48:24)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Print && Find actions for the parts :)
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 2efb62c081ed7cc1ae5db9e2e3de1ff5f8bef20c 
>   src/findbar.cpp 3f7825da449e2631da912aef479a79bc9234fdfd 
>   src/mainview.h 29162dd1875166747898a0453b331453c93a0624 
>   src/mainview.cpp beaf4e21e24ed5d536a8aeea2966c1e35b556823 
>   src/mainwindow.h 0395db4dabaa456908ef4778a9fe1a0958135daf 
>   src/mainwindow.cpp d5f82d97715f406cd9c7a194bfa5c069c2d8ce71 
>   src/protocolhandler.cpp a29ff366186b9cf1b523536ac3a60bd91f4bb5c9 
>   src/webpage.cpp 2347b6d86831cdebc9ff1eecd670cf1a6587c1fe 
>   src/webtab.h 3fd4f793babf8f715ab0702d5504187484ae251f 
>   src/webtab.cpp 0a55060b024bda0b06e1e5235ffb3b631e8234de 
>   src/webview.cpp 8be744ade071fabfd1c602099d51b52af93d531c 
> 
> Diff: http://git.reviewboard.kde.org/r/100143/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101111/924a309e/attachment.htm