[rekonq] Re: Review Request: Small bookmark API clean-up

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100126/#review276
-----------------------------------------------------------



src/bookmarks/bookmarkowner.h
<http://git.reviewboard.kde.org/r/100126/#comment222>

    You should probably change here the parameter name to bkGroup or something like that.



src/bookmarks/bookmarkowner.cpp
<http://git.reviewboard.kde.org/r/100126/#comment223>

    uhm... letting this without a parent will probably leak mem using it.
    The same applies in the other occasions you removed it.


- Andrea


On 2010-11-01 16:34:59, Jon Ander Peñalba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100126/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 16:34:59)
> 
> 
> Review request for rekonq and Yoann Laissus.
> 
> 
> Summary
> -------
> 
> I've done some clean-up to the bookmark API.
> There are still some things I want to improve, I hope to work on it soon, but I've been busier  than expected lately.
> 
> This diff is more than one commit, if you want to see each commit look at my personal clone: http://gitorious.org/~Jonan/rekonq/jonans-mainline/commits/bookmark
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkowner.h 573e4ee 
>   src/bookmarks/bookmarkowner.cpp 77af9b1 
>   src/bookmarks/bookmarkprovider.cpp ccdc326 
>   src/bookmarks/bookmarkscontextmenu.h d669eef 
>   src/bookmarks/bookmarkscontextmenu.cpp 93df6ce 
>   src/bookmarks/bookmarkspanel.h f042d4c 
>   src/bookmarks/bookmarkspanel.cpp f732cb2 
>   src/bookmarks/bookmarkstoolbar.cpp 4449d92 
>   src/history/historypanel.h 0a5ae21 
>   src/history/historypanel.cpp 28f7f4e 
>   src/urlpanel.h 722eeae 
>   src/urlpanel.cpp b3e8b2f 
> 
> Diff: http://git.reviewboard.kde.org/r/100126/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Ander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101103/1e20f89f/attachment.htm