[rekonq] [PATCH] Disable auto scroll

Benjamin Poulain benjamin.poulain at nokia.com
Fri May 21 11:21:27 CEST 2010


ext Cédric Bellegarde wrote:
>> here a small patch to add an option to disable autoscolling.

+    _canEnableAutoScroll = !ReKonfig::disableAutoScroll() && 
!result.isContentEditable()  && result.linkUrl().isEmpty();

There are two spaces before the second &&. Not your fault obviously but 
the patch is an opportunity to fix it :)


+       <widget class="QCheckBox" name="kcfg_disableAutoScroll">
+        <property name="text">
+         <string>Disable auto scrolling</string>
+        </property>
+       </widget>

I would add a tooltip on the widget. If I have no idea what auto 
scrolling is, I would look for a tooltip to explain it.


cheers,
Benjamin


More information about the rekonq mailing list