[rekonq] Cedric's patches
Andrea Diamantini
adjam7 at gmail.com
Wed May 12 14:58:20 CEST 2010
On Wednesday 12 May 2010 12:33:54 Cédric Bellegarde wrote:
> Le mercredi 12 mai 2010 12:02:53, vous avez écrit :
> > button size patch
> >
> > This patch tries to fix button behavior when they have text inside. I
> > didn't merge it, thinking it has to be moved upstream (ktoolbar code)
>
> I'm not sure this "king of hack" can go in kdelibs, what's your point of
> view on how to fix this ?
>
> However, i was planning to do some testing (it should be simple) moving
> reload/stop button to urlbar. Will this be pertinent? Does it break kde
> guidelines ?
>
> Regards,
I think kdelibs is full of these "hacks". Moreover this patch doesn't require
public changes at all, sure does not lead to crashes and fix a specific
"strange" behavior.
Moving the problem there will also help having more feedback about and
eventually hearing some different solutions.
Regards,
--
Andrea Diamantini, adjam
GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F
rekonq project
WEB: http://rekonq.sourceforge.net
IRC: rekonq at freenode
More information about the rekonq
mailing list