[rekonq] Re: remove 'set encoding' menu entry and bug 251264

[Andrea Diamantini]

On Sunday 26 December 2010 15:13:37 nihui wrote:
> hi all
> Any comments ?
> 
> best wishes,
> nihui
> 
> At 2010-12-12 20:32:14，nihui <shuizhuyuanluo at 126.com> wrote:
> >It seems that there was some thing wrong with my mail client ---- It ate
> >all the line breaks.  o_o
> >
> >so I send this again. sorry for the annoyance.
> >
> >==========================================
> >
> >Subject: remove 'set encoding' menu entry and bug 251264
> >
> >hi all
> >
> >I suggest to remove 'set encoding' menu entry. The action can be moved
> >into configuration dialog. This menu action is intended to be used to
> >change the default text encoding if the current webpage.Unfortunately,
> >this action only takes effect if the web page doesn't have its
> >content-type chatset information, which is rarely happened. So the menu
> >entry is totally useless in 99% situations since nearly all the sites
> >provide the basic charset metadata.
> >
> >If the current page has its charset content-type metadata, webkit engine
> >will use the charset provided with the page for the text encoding
> >regardless the DEFAULT text encoding set by the menu entry.
> >
> >Another suggestion is to revert the changes for the bug 251264
> >http://bugs.kde.org/show_bug.cgi?id=251264
> >The reason is that the change actually did not fix the problem. Changing
> >the default encoding from gb2312 to gb18030 dose not make sense if the
> >web page contained charset=gb2312 while actually encoded in gb18030. The
> >issue of bug 251264 should be an issue in webkit, not rekonq.
> >http://bugreports.qt.nokia.com/browse/QTBUG-15407
> >
> >best wishes,
> >nihui
> >
> >_______________________________________________
> >rekonq mailing list
> >rekonq at kde.org
> >https://mail.kde.org/mailman/listinfo/rekonq

Hi nihui,
I'm very sorry for the long delay replying here...
I worked very hard in this period and I could not play a lot with rekonq. But 
now it's Christmas and I'm on holidays :D

I tested your assertions and I can now say... you are right!
I completely misunderstood the meaning of the "setEncodings" methods, thinking 
they were able to change it "on the fly" instead of settings a "default if 
nothing else has been set one" and I implemented those (two) changes with that 
in mind.
I'll move that menu ASAP to the setting dialog. Any suggestions on how to 
implement the "change encodings on the fly" feature?
	
Regards,

PS: not sure if you are subscribed to the list. I CC'ed you :)

-- 
Andrea Diamantini, adjam
GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F

rekonq project
WEB: http://rekonq.kde.org
IRC: rekonq at freenode
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101229/3a614dd2/attachment-0001.htm