[rekonq] Re: Review Request: go through website history with horizontal scroll wheel buttons

[Andrea Diamantini]

> On 2010-12-20 14:16:27, Jon Ander Peñalba wrote:
> > I like this patch. I'll try it when I get home and if no one is against it I'll push it to master.
> 
> Andrea Diamantini wrote:
>     I don't have a mouse at all, so that I cannot properly test it: I'll trust Jon's testing. I just recommend to "stress-test" the patch before merging.
> 
> Felix Rohrbach wrote:
>     I'm using it since tuesday and it works well. The only thing I noticed is that sometimes the url bar shows the wrong url, but as I could reproduce this without this patch I don't think that it's related (it seems to happen if you go back in history while the page is loading - I'll create a bug report if there is no such one yet).
> 
> Felix Rohrbach wrote:
>     Bug report is here: https://bugs.kde.org/show_bug.cgi?id=260844 . As I could reproduce the bug without the patch installed I think it's not related to my patch. So could someone please mege the patch into git?

I think it needs someone else review before merge.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100213/#review579
-----------------------------------------------------------


On 2010-12-20 19:33:15, Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100213/
> -----------------------------------------------------------
> 
> (Updated 2010-12-20 19:33:15)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Some mouses have scroll wheels that you can press to the left or to the right side. With this patch you can use them to go through the website history of a tab (like in Opera).
> 
> I don't have git access, so if you like this patch, please merge it yourself into master.
> 
> 
> Diffs
> -----
> 
>   src/mainview.h 1d04d28 
>   src/mainview.cpp 850101e 
>   src/mainwindow.cpp 447885d 
>   src/rekonq.kcfg 33a0775 
>   src/settings/settings_general.ui dccf479 
>   src/webview.h 9518b74 
>   src/webview.cpp aeaf92b 
> 
> Diff: http://git.reviewboard.kde.org/r/100213/diff
> 
> 
> Testing
> -------
> 
> compiles & works
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101227/8a944683/attachment.html