[rekonq] Re: Review Request: GCI Taks: Added Support for New Tab Page Themes and Theme Manager

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100214/#review631
-----------------------------------------------------------


Ok, better than previous, but with a lot of things to change, IMHO.
This thing has to work in the same way people changes desktop image background, grabbing it from the Internet.
So, just the "theme manager" has to be used, showing the "default" theme and eventually a couple of other ones. People has to see (and choice) theme screenshots, NOT compressed files where themes effectively are. And just ONE button to choose your theme, NOT the "Change theme" and the "Theme Manager" actions.
>From an user POV, I don't see the difference.

- Andrea


On 2010-12-21 17:13:02, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100214/
> -----------------------------------------------------------
> 
> (Updated 2010-12-21 17:13:02)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Added support for changing Rekonq's new tab page theme.
> * Added a Theme Manager
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f0310b4 
>   src/newtabpage.h be02d9d 
>   src/newtabpage.cpp 7dcc958 
>   src/newtabpagetheme.h PRE-CREATION 
>   src/newtabpagetheme.cpp PRE-CREATION 
>   src/newtabpagetheme.ui PRE-CREATION 
>   src/thememanager.h PRE-CREATION 
>   src/thememanager.cpp PRE-CREATION 
>   src/thememanager.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100214/diff
> 
> 
> Testing
> -------
> 
> * Tested by me and Panagiotis Papadopoulos and it works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101227/c13ff587/attachment.htm