[rekonq] Re: Review Request: Highlight updated tabs
Felix Rohrbach
fxrh at gmx.de
Wed Dec 22 14:18:52 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100224/#review600
-----------------------------------------------------------
The author of the patch changed it and put it on reviewboard here: http://git.reviewboard.kde.org/r/100230/
Closing this one now.
- Felix
On 2010-12-20 23:08:46, Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100224/
> -----------------------------------------------------------
>
> (Updated 2010-12-20 23:08:46)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).
>
> Patch by fritz_van_tom.
>
> It's a nice patch, but maybe we should remove the blinking, as this is very distracting.
>
> I don't have a kde git account, so please merge it if you like it.
>
>
> Diffs
> -----
>
> src/mainview.cpp 850101e
> src/tabbar.h acd8e2f
> src/tabbar.cpp 286d7d4
>
> Diff: http://git.reviewboard.kde.org/r/100224/diff
>
>
> Testing
> -------
>
> compiles and works
>
>
> Thanks,
>
> Felix
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101222/941ccd18/attachment.htm
More information about the rekonq
mailing list