[rekonq] Re: Review Request: Folder drag and drop support for the bookmark toolbar

[Yoann Laissus]

> On 2010-12-19 16:42:30, Andrea Diamantini wrote:
> > I trust your code and testing it seems working well, but in ONE occasion: dropping one url from a subdir does NOT work.

Thanks for testing. This patch only add drag and drop support for root folders. Drag & drop support for subfolder items is planned for a next patch.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100220/#review578
-----------------------------------------------------------


On 2010-12-18 21:36:34, Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100220/
> -----------------------------------------------------------
> 
> (Updated 2010-12-18 21:36:34)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> - Bookmark folders can now be dragged and dropped in the toolbar.
> - Drop a bookmark folder in the WebView no longer crash rekonq but open this folder in new tabs
> - Fix some crash when a single bookmark is dropped in the WebView (incorrect URL)
> - Port the drag icon to IconManager
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkprovider.cpp fe038b2 
>   src/bookmarks/bookmarkstoolbar.cpp 63092b8 
>   src/webview.h 9518b74 
>   src/webview.cpp e90b8da 
> 
> Diff: http://git.reviewboard.kde.org/r/100220/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101220/0181bdee/attachment.htm