[rekonq] Re: Review Request: Icon for add opensearch engine

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100064/#review577
-----------------------------------------------------------


I tested it but I couldn't go deep studying your code. Something I noticed about:
- now shortcuts seem saved well
- I cannot yet find "manga france" in the webshortcut dialog. Should it be there?
- Obviously, I cannot change/delete it. If I can add, it seems normal. Isn't it.
- setting an used shortcut seems working (ie preventing me doing it), but the string cannot be seen. I'll publish a screenshot, if you need.
- I set the mf shortcut for Manga France. Using it (eg: "mf:ciao") searches the string "mf:ciao" on wikipedia (my default search engine).


- Andrea


On 2010-12-18 20:26:57, Lionel Chauvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100064/
> -----------------------------------------------------------
> 
> (Updated 2010-12-18 20:26:57)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Icon at the right of the urlbar that allows to add an opensearch engine
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f0310b4 
>   src/application.cpp 95aa9cf 
>   src/data/CMakeLists.txt 5f49994 
>   src/data/beolingus.xml PRE-CREATION 
>   src/data/db_opensearch.json PRE-CREATION 
>   src/data/de2en.xml PRE-CREATION 
>   src/data/dictfr.xml PRE-CREATION 
>   src/data/facebook.xml PRE-CREATION 
>   src/data/kde_techbase.xml PRE-CREATION 
>   src/data/kde_userbase.xml PRE-CREATION 
>   src/data/voila.xml PRE-CREATION 
>   src/data/wikia.xml PRE-CREATION 
>   src/data/wikipedia.xml 4e15208 
>   src/data/wiktionary.xml PRE-CREATION 
>   src/data/wr_english.xml PRE-CREATION 
>   src/data/youtube.xml PRE-CREATION 
>   src/mainwindow.cpp 447885d 
>   src/opensearch/opensearchengine.cpp 9d5e866 
>   src/opensearch/opensearchmanager.h 4f42b4a 
>   src/opensearch/opensearchmanager.cpp e5afc14 
>   src/opensearch/suggestionparser.cpp 4ed13e1 
>   src/settings/generalwidget.cpp 642813a 
>   src/settings/settingsdialog.cpp a3b4f97 
>   src/urlbar/listitem.h f5f1153 
>   src/urlbar/listitem.cpp f29a0e9 
>   src/urlbar/urlbar.h 67a693c 
>   src/urlbar/urlbar.cpp d93aeb7 
>   src/urlbar/urlresolver.cpp 57d6ca6 
>   src/urlbar/webshortcutwidget.h PRE-CREATION 
>   src/urlbar/webshortcutwidget.cpp PRE-CREATION 
>   src/webtab.h 12f528d 
>   src/webtab.cpp bac73fe 
> 
> Diff: http://git.reviewboard.kde.org/r/100064/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lionel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101219/8af4da54/attachment.htm