[rekonq] Re: Review Request: Icon for add opensearch engine

[Lionel Chauvin]

> On 2010-12-13 14:19:07, Andrea Diamantini wrote:
> > Sorry Lionel, again I merged your patch with your suggestion, compiled and tested it. I visited around 30 sites (quite all from the xml/json list and some more) and  I really cannot see anything different from before. . 
> > Can you attach here some suggestions/explanations for testing this feature?
> 
> Lionel Chauvin wrote:
>     If you try a website of the list, it is normal you don't see anything different because they are already added.
>     You can try this website: http://www.manga-france.fr , the icon at the right of the urlbar should appear. You can verify if the webshortcut is created, if an entry is added in the db_opensearch.json and if the 
>     xml is downloaded.
> 
> Andrea Diamantini wrote:
>     I do as you suggest. Loaded manga-france, seen webshortcut icon, clicked over, chose "gg" shortcut (the google one). nothing complained :(
>     Then I started searching in the webshortcuts list (the menu in config settings) and I couldn't find it. I now can no more edit/delete it.
>     Then I understood we are talking about a different feature, based on the same webshortcut. BAD!
>     IMHO, the best we can do here is providing opensearch suggestions for the engines present in kdebase_runtime. Without letting users add/modify/delete them, but just choose if use them or not.
>     Last (but not less important), your implementation cannot work at all installing it, as it tries to write on some root-owned dirs.
>     
>     
>     Very very last, not really related to your merge request: reviewboard sucks. I truly think KDE needs a way "git-integrated" to handle revisions. Reading today all merge requests and reviews I noticed around 90% of them talking of style/space/capital letters/brackets (that are good, but...) and really few of them saying: "it doesn't work/compile/has been right/bad implemented" and so on.
> 
> Lionel Chauvin wrote:
>     "chose "gg" shortcut (the google one). nothing complained :("
>     Ok I must fix that, it is not so difficult.
>     
>     "I couldn't find it."
>     weird
>     It is perhaps due to the conflict with google. I must investigate.
>     
>     "it tries to write on some root-owned dirs"
>     oO
>     Are you sure about that ?
>     
>     "reviewboard sucks"
>     true
>     You must update master, create a branch, download manually the patch, apply the patch, build and test.
>     It was easier to create a branch, pull a branch from an other git repository, build and test.
>
> 
> Andrea Diamantini wrote:
>     your code basically adds files in the $INSTALL_DIR/share/apps/rekonq/opensearch/ dir and update a file there (the db_opensearch.json one). Isn't it? If so, yes: you are trying to write in some root-owned dirs.

You are right I will fix that.


- Lionel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100064/#review529
-----------------------------------------------------------


On 2010-12-12 20:05:44, Lionel Chauvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100064/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 20:05:44)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Icon at the right of the urlbar that allows to add an opensearch engine
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f0310b4 
>   src/application.cpp 95aa9cf 
>   src/data/CMakeLists.txt 5f49994 
>   src/data/beolingus.xml PRE-CREATION 
>   src/data/db_opensearch.json PRE-CREATION 
>   src/data/de2en.xml PRE-CREATION 
>   src/data/dictfr.xml PRE-CREATION 
>   src/data/facebook.xml PRE-CREATION 
>   src/data/kde_techbase.xml PRE-CREATION 
>   src/data/kde_userbase.xml PRE-CREATION 
>   src/data/voila.xml PRE-CREATION 
>   src/data/wikia.xml PRE-CREATION 
>   src/data/wikipedia.xml 4e15208 
>   src/data/wiktionary.xml PRE-CREATION 
>   src/data/wr_english.xml PRE-CREATION 
>   src/data/youtube.xml PRE-CREATION 
>   src/mainwindow.cpp c9863f0 
>   src/opensearch/opensearchengine.cpp 9d5e866 
>   src/opensearch/opensearchmanager.h 4f42b4a 
>   src/opensearch/opensearchmanager.cpp e5afc14 
>   src/opensearch/suggestionparser.cpp 4ed13e1 
>   src/settings/generalwidget.cpp 642813a 
>   src/settings/settingsdialog.cpp a3b4f97 
>   src/urlbar/listitem.h f5f1153 
>   src/urlbar/listitem.cpp f29a0e9 
>   src/urlbar/urlbar.h 67a693c 
>   src/urlbar/urlbar.cpp 1f4a036 
>   src/urlbar/urlresolver.cpp 57d6ca6 
>   src/urlbar/webshortcutwidget.h PRE-CREATION 
>   src/urlbar/webshortcutwidget.cpp PRE-CREATION 
>   src/webtab.h 12f528d 
>   src/webtab.cpp bac73fe 
> 
> Diff: http://git.reviewboard.kde.org/r/100064/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lionel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101214/6fd31e94/attachment.htm