[rekonq] Re: Review Request: GCI Task: Pulldown menu for Forward button

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100206/#review525
-----------------------------------------------------------


a few more changes and we should get there.


src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100206/#comment417>

    could be declared const ?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100206/#comment418>

    This 8 should be declared as a local const variable, that should prevent the code from becoming unreadable in the future.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100206/#comment420>

    indenting is broken from here on, should be back to the left.


- Pierre


On 2010-12-13 13:29:39, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100206/
> -----------------------------------------------------------
> 
> (Updated 2010-12-13 13:29:39)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Added pulldown menu for multiple steps to the "Forward" button.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 33fd202 
>   src/mainwindow.cpp c9863f0 
> 
> Diff: http://git.reviewboard.kde.org/r/100206/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101213/e8aac4e5/attachment-0001.htm