[rekonq] Re: Review Request: GCI Task: Copy Context Menu for Network Analyzer

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100198/#review523
-----------------------------------------------------------


I'd rather you changed the contextMenuPolicy and switched to a signal/slot approach as mentioned earlier. Stuffing all this in the contextMenuEvent is a bit less elegant IMHO.

- Pierre


On 2010-12-13 13:10:13, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100198/
> -----------------------------------------------------------
> 
> (Updated 2010-12-13 13:10:13)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Copy context menu for Network Analyzer.
> 
> 
> Diffs
> -----
> 
>   src/analyzer/networkanalyzer.h 9e38663 
>   src/analyzer/networkanalyzer.cpp c5b0883 
> 
> Diff: http://git.reviewboard.kde.org/r/100198/diff
> 
> 
> Testing
> -------
> 
> Tested and works cool!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101213/4620b73e/attachment-0001.htm