[rekonq] Re: Review Request: opening plain text emails in email application

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100123/#review520
-----------------------------------------------------------


Hope it's not too late for some comments...


src/webview.cpp
<http://git.reviewboard.kde.org/r/100123/#comment409>

    Style: trailing whitespace



src/webview.cpp
<http://git.reviewboard.kde.org/r/100123/#comment408>

    Try to avoid magic numbers, same as here:
    http://git.reviewboard.kde.org/r/100205/
    
    and same comment for truncatedURL -> truncatedUrl applies too.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100123/#comment411>

    Creating a new action could make this more readable.
    const KAction * const sendEmailAction = ...



src/webview.cpp
<http://git.reviewboard.kde.org/r/100123/#comment410>

    style again.


- Pierre


On 2010-10-31 18:53:33, Panagiotis Papadopoulos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100123/
> -----------------------------------------------------------
> 
> (Updated 2010-10-31 18:53:33)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This adds support for opening a plain text email address in an appropriate email application.
> 
> I need someone that can help me with the TODO part… Currently when you execute the action to send an email, rekonq will open up a new tab first (due to the usage of the openLinkInNewTab slot). IMHO this is not necessary…
> 
> (note: I am no developer, my programming skills are *very* low :-D This is mostly a “copy, paste and modify” job :-))
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp 8be744a 
> 
> Diff: http://git.reviewboard.kde.org/r/100123/diff
> 
> 
> Testing
> -------
> 
> worked here a week ago, but due to some weird problem on my installation (kmailservice failing to be started) it does not work today… weird 
> 
> 
> Thanks,
> 
> Panagiotis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101213/a9b235c3/attachment.htm