[rekonq] Re: Review Request: Use Ctrl+Left Click to open a link in a new focused tab, even when the option "Open tabs in background" is enabled.

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100201/#review515
-----------------------------------------------------------


Your patch works well :)
Anyway, from coding point of view, I think you can achieve the same result, just changing one line:
webview.cpp:618 --> emit loadUrl(url, Rekonq::NewFocusedTab) 
and adding one simple comment. If you prefer your implementation for some reasons, please add some comments in your code and remove the no more used loadUrlinNewTab slot.

- Andrea


On 2010-12-12 19:07:21, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100201/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 19:07:21)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Use Ctrl+Left Click to open a link in a new focused tab, even when the option "Open tabs in background" is enabled.
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp e90b8da 
> 
> Diff: http://git.reviewboard.kde.org/r/100201/diff
> 
> 
> Testing
> -------
> 
> Tested by me and Panagiotis Papadopoulos and it works ok.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101213/af3be18e/attachment-0001.htm