[rekonq] Re: Review Request: GCI Task: Pulldown menu for Forward button

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100206/#review505
-----------------------------------------------------------


The indenting is a minor problem, but you could avoid this by setting your editor properly (Qt Creator should have this option checked by default, "replacing tabs with spaces" that is).
I'm more worried about the broken diff for mainwindow.cpp, in any case I took a quick look at the downloaded diff, once again, careful with magic numbers ! This '8' that's used in a few lines should really be declared as a const int maxHistoryItemCount or something.


src/mainwindow.h
<http://git.reviewboard.kde.org/r/100206/#comment398>

    /!\ no tabs for indenting, should be spaces.


- Pierre


On 2010-12-12 19:06:52, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100206/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 19:06:52)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Added pulldown menu for multiple steps to the "Forward" button.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 33fd202 
>   src/mainwindow.cpp c9863f0 
> 
> Diff: http://git.reviewboard.kde.org/r/100206/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101212/f87f744f/attachment.htm