[rekonq] Re: Review Request: GCI Task: Saving zoom settings for each web site

Lionel Chauvin megabigbug at yahoo.fr
Sun Dec 12 18:06:09 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100207/#review502
-----------------------------------------------------------



src/application.h
<http://git.reviewboard.kde.org/r/100207/#comment395>

    Are you sure that the application class is the right place ?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100207/#comment396>

    the forward menu is related to the zoom feature ?
    (one patch, one feature)



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100207/#comment397>

    wrong code ident


- Lionel


On 2010-12-12 14:08:29, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100207/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 14:08:29)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Save zoom settings for each web site
> 
> 
> Diffs
> -----
> 
>   src/application.h b30e337 
>   src/application.cpp 95aa9cf 
>   src/mainwindow.h 33fd202 
>   src/mainwindow.cpp c9863f0 
>   src/webview.h 9518b74 
>   src/webview.cpp e90b8da 
>   src/zoombar.cpp a895466 
> 
> Diff: http://git.reviewboard.kde.org/r/100207/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101212/d7facf5a/attachment.htm 


More information about the rekonq mailing list