[rekonq] Re: Review Request: GCI Task: Context Menu Improvements

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100205/#review500
-----------------------------------------------------------



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment391>

    I would put the two variables just before the  if (text.length() > maxTextSize) so they are used next to where they are declared.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment394>

    I guess this should be truncatedUrl for consistency.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment393>

    I would use truncatedURL in the if here for consistency:
        if (truncatedURL.length() > maxTextSize)



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment392>

    Spaces on an empty line :)


- Benjamin


On 2010-12-12 12:38:57, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100205/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 12:38:57)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Find action
> * Print action
> * Open URL-like text in new tab/window
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp e90b8da 
> 
> Diff: http://git.reviewboard.kde.org/r/100205/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101212/3824cf4a/attachment.htm