[rekonq] Re: Review Request: GCI Task: Context Menu Improvements

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100205/#review498
-----------------------------------------------------------



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment386>

    Please use explicit construction : 
    KUrl urlLikeText(text);



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment387>

    Try to avoid magic numbers.
    You can define on the previous line:
    const int maxTextSize = 18;
    const int truncateSize = 15;
    
    Reading (text.length() > maxTextSize) is clearer than > 18.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment388>

    QL1S("...")



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment389>

    You already have the url: urlLikeText. You can reuse it here.



src/webview.cpp
<http://git.reviewboard.kde.org/r/100205/#comment390>

    Same as previous comment, you can reuse the url object created before.


- Benjamin


On 2010-12-12 12:17:05, Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100205/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 12:17:05)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> * Find action
> * Print action
> * Open URL-like text in new tab/window
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp e90b8da 
> 
> Diff: http://git.reviewboard.kde.org/r/100205/diff
> 
> 
> Testing
> -------
> 
> Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101212/01c641bd/attachment.htm