[rekonq] Re: Google Code-In: Second Submission

Andrea Diamantini adjam7 at gmail.com
Wed Dec 8 23:36:32 CET 2010


On Wednesday 08 December 2010 18:19:32 Benjamin Poulain wrote:
> I am not sure how this connection works:
> connect( _requestList, SIGNAL(customContextMenuRequested(QPoint)), this,
> SLOT(contextMenuEvent(QContextMenuEvent*))) ;
> The arguments seem incompatible to me.

Yes, code is wrong there and need fixes.

IMHO, the copyURL() method should be renamed as "copyUrl()".

Apart then those, it seems working well.

Regards,
-- 
Andrea Diamantini, adjam
GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F

rekonq project
WEB: http://rekonq.sourceforge.net
IRC: rekonq at freenode
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101208/11a5f0a6/attachment.htm 


More information about the rekonq mailing list