[rekonq] don't focus tab on middle mouse click

Panagiotis Papadopoulos pano_90 at gmx.net
Sun Oct 25 14:41:43 CET 2009


On Sunday 25 October 2009 11:30:40 Ronny Scholz wrote:
> Am Sonntag, 25. Oktober 2009 11:04:15 schrieb Andrea Diamantini:
> > On Sunday 25 October 2009 02:53:52 Ronny Scholz wrote:
> > > This is a fix for bug https://bugs.kde.org/show_bug.cgi?id=205902
> > >
> > > The problem is that the click event of the middle mouse button onto a tab
> > > activates it. Therefore, if a tab in the background is closed, the
> > >  currently activated tab looses the focus.
> > >
> > > With the attached patch, rekonq won't focus a tab on middle mouse click.
> > > However, we will also loose the possibility to move tabs with the middle
> > >  mouse button (left button still works though), so this fix may need some
> > >  discussion.
> > 
> > Why not just implementing a closeTab(index) call to middle mouse button
> >  click, instead of ignoring the event?
> > 
> 
> This is the current implementation. But mousePressed() is called before which 
> activates the tab to be closed.
> _______________________________________________
> rekonq mailing list
> rekonq at kde.org
> https://mail.kde.org/mailman/listinfo/rekonq
> 
> 

Ok, this patch fixed the behaviour described in the bugreport (thanks!), but it introduced another bug:

How to reproduce:

Open up rekonq, and start two new additional tabs.
Now switch the focus to the last tab and middle click on the first tab.

All tabs except the currently focused one are closed.


Greetings

pano


More information about the rekonq mailing list