[rekonq] Bug with new tab button

Cédric Bellegarde gnumdk at adishatz.1s.fr
Sat Nov 21 05:28:04 CET 2009


There is a bug with new tab button misplaced first time it is shown.

        // detecting Y position
        int newPosY = m_tabBar->height() - m_addTabButton->height();
        if(newPosY < 0)
            newPosY = 5;    // this hardcoded value is used in just ONE 
situation:
                            // the first time an user changes the "Always Show 
Tab Bar" settings
                            // try some better fixes, if you can :D

        m_addTabButton->move(newPosX, newPosY );

Why calculating newPosY? Shouldn't it be 0 everytime? I am missing something?

With m_addTabButton->move(newPosX, 0), new tab button placement is good (even 
the first time user changes always show tab bar).

Cédric


More information about the rekonq mailing list