[rekonq] NO MERGING ISSUES

[Domrachev Alexandr]

On 18 апреля 2009 04:58:26 Andrea Diamantini wrote:
> I wanna start this mail thanking all you again for your fantastic work
> and help to rekonq project.
> Questions about the no merging issues during these holidays are basically
> two I'm seeing in your clones.
> Clones are actually rekonq forks and as this always helps features and
> ideas to be implemented lets discerning quite hard.
>
> So here are some small rules to follow to help at best rekonq dev:
>
> 1.
> NO large commits. as avaddon just explained in one post some days ago (i
> read all just this morning), we have one fantastic rule:
>
> ONE feature <= ONE commit.
>
> So all we can push one feature with one or more commits, but one commit has
> to be about just 1 feature.

No comments :)
>
> 2.
> NO features non approved in master. For example I saw a beautiful side
> panel implementation. But rekonq will never have a side panel. That's
> because side panels are usability evils and I'd like rekonq to be "easy".

No I don't agree. If you don't like something it doesn't mean that that it shouldn't be in 
mainline. I've got more than 600 bookmarks... how I suppose to search through them?
	With menu? - No way.
	With urlbar dropdown? - yes it's better, but anyway not the same as side panel.
Easy - maybe, but I should be also easy to use.

> 3.
> NO unuseful re-implementations. I really spent one hour to review pawel
> Download class refactoring, that was able just to introduce just one bug
> (issue #?) and no more features.
Actually there is many features added with this implementation of download manager. It's 
solved many bugs. 

> Why do we feel the needing of doing such things??
Because we feel so :)
> And just to be honest, that class is copied from kget code.
Exactly. Rekonq is browser, KGet - download manager. I hope you can feel the difference.
Code good to download manager may not fit internet browser.


-- 
Best regards,
	Domrachev Alexandr.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/rekonq/attachments/20090418/1b7e6a30/attachment.sig