Review Request 116067: Implement WebSocket type.

[Nikita Skovoroda]

> On Feb. 26, 2014, 10:51 p.m., Anton Kreuzkamp wrote:
> > One issue and some minor nags. But nice code overall! Thank you! :)

Will fix everything tomorrow.


> On Feb. 26, 2014, 10:51 p.m., Anton Kreuzkamp wrote:
> > src/qtcore.js, line 3571
> > <https://git.reviewboard.kde.org/r/116067/diff/1/?file=246158#file246158line3571>
> >
> >     Just a small one, but I tend to omit the braces for oneliners. Just for consistency, please do that as well. :)

If you insist, I will remove them.

But that's generally a bad practice.

Haven't you heard where Apple got with omitting braces for one-liners?
iOS versions < 7.0.4 (current) are screwed, OS X versions < 10.9.2 (current, released a day ago) are screwed. All because of combination of using gotos and omitting braces for oneliners.


> On Feb. 26, 2014, 10:51 p.m., Anton Kreuzkamp wrote:
> > src/qtcore.js, line 3527
> > <https://git.reviewboard.kde.org/r/116067/diff/1/?file=246158#file246158line3527>
> >
> >     WebSocket.Null was not defined above.

Whoops.


- Nikita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116067/#review50990
-----------------------------------------------------------


On Feb. 25, 2014, 11:45 p.m., Nikita Skovoroda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116067/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 11:45 p.m.)
> 
> 
> Review request for QML Web and Anton Kreuzkamp.
> 
> 
> Repository: qmlweb
> 
> 
> Description
> -------
> 
> Implement WebSocket type.
> 
> A simple wrapper around javascript WebSocket class ( http://caniuse.com/websockets ).
> 
> API compatible with Qt.WebSockets (see https://qt.gitorious.org/qt/websockets ).
> The Qt.WebSockets module will be included in Qt 5.3 release: http://qt-project.org/wiki/New-Features-in-Qt-5.3#a12a092a739cea3499350adb459d86b0 .
> 
> 
> Diffs
> -----
> 
>   src/qtcore.js c219e2e 
> 
> Diff: https://git.reviewboard.kde.org/r/116067/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> I could send and recieve messages and get status updates.
> 
> 
> Thanks,
> 
> Nikita Skovoroda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/qmlweb/attachments/20140227/9061d621/attachment.html>