CI that doesn't run on MRs

[Ben Cooksley]

On Thu, Aug 21, 2025 at 7:02 AM Nate Graham <nate at kde.org> wrote:

>
>
> On 8/20/25 12:51, Ben Cooksley wrote:
> > On Tue, Aug 12, 2025 at 11:58 PM Nate Graham <nate at kde.org
> > <mailto:nate at kde.org>> wrote:
> >
> >
> >
> >     On 8/11/25 04:58, Ben Cooksley wrote:
> >      > Unfortunately the variable in question we were trying to rely on,
> >      > CI_MERGE_REQUEST_APPROVED is exclusive to Enterprise Edition:
> >      >
> >      > ben at sapphire:~/workspace/gitlab> grep -ir
> CI_MERGE_REQUEST_APPROVED *
> >      > ee/app/models/ee/merge_request.rb:          variables.append(key:
> >      > 'CI_MERGE_REQUEST_APPROVED', value: approved?.to_s) if approved?
> >      >
> >      > As such that functionality is not available to us.
> >      >
> >      > This means the options available to us are:
> >      > - Using a custom label (accessible via CI_MERGE_REQUEST_LABELS)
> >
> >     What does this look like?
> >
> >
> > It would be like any other label on a merge request.
> >
> > See Arch for instance on https://invent.kde.org/sysadmin/repo-
> > metadata/-/merge_requests/614 <https://invent.kde.org/sysadmin/repo-
> > metadata/-/merge_requests/614> - in this case the label would be
> > "Approved", "Ready" or something equivalent that means a bit more than
> > just "Run CI"
>
> Ah, that kind of label.
>
> I doubt that will work. We did a variant of this for approval before
> Gitlab CE backported the optional approvals feature, and it was a
> complete mess. Did not work at all. I think turning off the CI for draft
> merge requests would be a better approach if I had to choose between
> those options.
>

Just having a look at KWin at least, looks like the majority of MRs aren't
draft.

Before I make that change, which is really just removing the
force-to-manual-for-Plasma, could folks please go through outstanding MRs
and mark those that aren't ready to merge as draft?


> Nate
>

Thanks,
Ben
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20250821/201d5b2a/attachment.htm>