CI Utilisation and system efficiency

[Ingo Klöcker]

On Samstag, 19. April 2025 21:29:07 Mitteleuropäische Sommerzeit Ben Cooksley 
wrote:
> On Sun, Apr 20, 2025 at 7:21 AM Ingo Klöcker <kloecker at kde.org> wrote:
> > Sounds like we shouldn't be so trigger-happy clicking the Rebase button on
> > our
> > MRs when it's not really necessary. We could rebase locally and then
> > commit
> > the rebase together with other review changes.
> 
> If you don't rebase on Gitlab then it won't detect that a merge request has
> been merged when you push the changes so probably not the best to do it
> that way.

I don't suggest to do the merge to master manually. I suggest not to do the 
rebase of the MR branch on master (if master got new commits) via GitLab if 
one needs to do more changes to the MR.

> > On the other hand, GitLab doesn't really make it easy to avoid running
> > pipelines unnecessarily often because "Apply Suggestion" will trigger a
> > pipeline even if other review comments require local changes. So, either
> > we
> > have to cancel the pipeline that GitLab started automatically if we need
> > to
> > make more changes. Or we have to refrain from using "Apply Suggestion" and
> > instead apply the suggestions manually locally. Neither approach is
> > convenient.
> 
> Apply suggestion should allow batching - see
> https://docs.gitlab.com/user/project/merge_requests/reviews/suggestions/#bat
> ch-suggestions

Yes, it does. But GitLab will still run a pipeline when you submit the batch.

Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20250419/065c120b/attachment.sig>