Monday meeting notes for 27/11/2023

[Méven]

Méven

kcm wallpaper https://invent.kde.org/plasma/kpipewire/-/merge_requests/91
should be ready for last reviews, tests and review welcome to make it
before beta
I want to improve it further during beta

Kai

    I was wondering if we should change out quick controls styles to use
down instead of pressed. That’s Qt‘s “buton appears pressed down” state. My
main motivation is that “pressed” is read-only whereas “down” can be
overridden. In KRunner for example we have a TapHandler doing the input and
so the “pressed” state of the delegate doesn’t work and I also cannot fake
it because “pressed” is read-only. Seems most of Qt’s own styles also use
“down”?

    > ahiemstra
    > : re down vs. pressed, qqc2-desktop-style already should be using
down in most places, if not it's a bug

        Digital Clock: Localized custom date format, too, please review:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3562
            The Qt.formatDate situation under Qt 6 is quite annoying,
depending on what you want (ISO date, long/short format, custom format) you
have to use three distinct APIs.
        Fixed “Add to favorites” not updating its state live in Kickoff, it
was caching the menu erroneously
        Fix for “Add to favorites” not working at all for search results in
Kickoff, please review
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3559
        Handle parent window changing in waylandtasksmodel
            x-d-p app chooser dialog sets its parent window after show
(which should be fixed somehow) but we should be handling this case
regardless
        Found that kapplymousetheme wasn’t really working on X because it
checked for m_dpy being null:
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1872
        Use KNotificationJobUiDelegate for Folder View drop
            seems most jobuidelegate APIs still use QWidget for the window
so I think I cannot pass the desktop window… not sure if we can still fix
that for KF6 and how widespread of a change that would be :/

    Wayland:

    Prompted by the desktop window annoyingly stealing focus whenever
Plasma starts, I have been doing some investigation on xdg activation, with
the goal being XDG activation as the only means to activate windows, don’t
just activate them when they show up. There’s a GitLab issue I made to
track this effort: https://invent.kde.org/plasma/kwin/-/merge_requests/4659

        Added an option to make Focus stealing “extreme” do that for easier
development
        Made a patch for Qt to requestActivate on window show:
https://codereview.qt-project.org/c/qt/qtwayland/+/519444
            Found that KWin rejects an activation on show because
readyForPainting() will be false at this point, I’m unsure how to address
this
            however with that worked around and the aforementioned Qt
patch, the system is 90% usable in this mode already!
                global shortcuts (KRunner, app launch) set a proper token,
opening a new window from another window (e.g. file dialog) works just fine
            we should probably run this in Gnome Shell, too and see if it
causes any unwanted side-effects there
        Working on fixing scaling of startupfeedback cursor on high-dpi but
it’s a lot tougher than I hoped
            Perhaps we should just rewrite it in QML…

    I also made the window kill prompt work on Wayland and redesigned it,
quite happy with the outcome even though the implementation was a lot more
involved than I anticipated yet still a fun exercise:
https://blog.broulik.de/2023/11/freezing-in-style/

    Wonder if we should do another Wayland governance meeting early
December? I’d really like to see
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/228
(xdg dialog) in Qt 6.7…
    Frameworks:

        ListJob use flags instead of “includeHidden” bool, please review
(breaing API change)
https://invent.kde.org/frameworks/kio/-/merge_requests/1488
        Worked on fractional scaling support in PreviewJob
            even if we don’t end up doing that now is the chance to change
the wire format to allow for it (int → qreal)

    Apps:

    Qt Contributor’s (and World) Summit is later this week \o/

        Fixed frational scaling in Dolphin’s thumbnail generation code
            Generally you can keep in mind that qApp->devicePixelRatio()
will be integer on Wayland, don’t use that.
                QIcon::pixmap() defaults to it unless you specify a dpr
manually! (the pixmap(QWindow*) API is gone in Qt 6).
            You need to use the window’s dpr since the fractional scale
interface is attached to a window and the fallback Qt uses is based on the
wl_output and thus integer.

    Qt:

        Finished making Item.grabToImage grab with devicePixelRatio:
https://codereview.qt-project.org/c/qt/qtdeclarative/+/494128
            Fixed the tests, now waiting for approval :(
        Some more Wayland drag and drop related fixes, please review:
            Skip bogus “DELETED” format sent by Firefox, should fix the 1s
delay when dragging an image out of Firefox to the desktop:
https://codereview.qt-project.org/c/qt/qtwayland/+/518019
                Generally KDeclarative DropArea has the issue that its
QMimeData copy fetches the contents of all provided formats so it will
always potentiall block somewhere :/
            Handle when text/x-moz-urls is UTF-8 instead of UTF-16, Chrome
sometimes does that:
https://codereview.qt-project.org/c/qt/qtwayland/+/518017
            Return converted (text/x-moz-urls → text/uri-list) format in
formats(), too: https://codereview.qt-project.org/c/qt/qtwayland/+/518018
                Fixes dragging images from Chrome to the desktop


notmart

    just some misc small fixes
    fixed a crash on teardown due to systray being special
    introduced an error message when the user tries to use a plasma5
palsmoid on plasma6:
    now plasmoids have the minimum required api in their metadata
    widget explorer shows disabled with error message plasmoids for the
wrong plasma version
    fixed opening and closing applets with global shortcut
    fixed a glitch in taskmanager config window
    fix for a weird crash in kirigami in very recent qt checkouts that
prevented systemsettings to start (upstream bug reported)
    crash fix for removing panels from the containments configuration window


redstrate
    just one thing from me, if you have a display drawing tablet please
help me test
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1833

Natalie Clarius

    Applets: Did some more refinements for the battery and brightness
split, and added status icon overlays, middle click and scroll actions for
the battery applet:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3601,
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3531,
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3557
    Looked a bit into how power profiles deamon works and what
alternataives there are,
https://invent.kde.org/plasma/powerdevil/-/issues/31, tuned
    Suspending: Started a fix for
https://bugs.kde.org/show_bug.cgi?id=476492 and
https://bugs.kde.org/show_bug.cgi?id=466025 but the logic doesn't work out,
need to rethink what we want to do exactly
https://invent.kde.org/plasma/powerdevil/-/merge_requests/279


David Redondo at davidre:kde.org
    I ported the plasma-firewall kcm to TreeView which still quick controls
1
    Did some Fixes to the new TreeViewDelegate in the style


Xaver
    I implemented and merged more HDR settings. You can work around
displays making colors look too desaturated in HDR mode now, and actually
set the brightness of SDR content
    there's some new kscreen-doctor-only settings you can use to override
wrong or missing brightness metadata from the display too. A GUI for that
will come later
    I still need to implement the brightness slider for powerdevil, but
that can go in as a bugfix (as the ddcutil slider is still there but
doesn't do anything in HDR mode with most displays)
    merged a change to make sRGB content use the gamma 2.2 EOTF instead of
the piece-wise transfer function, to make the result with dark colors more
correct with color management and HDR
    there's performance issues with color management on Vlad's laptop, but
of course not on any of my hardware. If you too are seeing bad performance
with an ICC profile set on Wayland, please report it so that we have a
better chance of figuring out why this is happening

    I'll be pretty busy with uni stuff this and maybe next week too, so I
won't be around as much. Do still ping me if there's anything beta-relevant
that I should give my input for, but otherwise I'll be available again in a
week or two


fusionfuture

    The at-spi webdriver now supports image comparison, which enables more
testing possibilities. See
https://appium.github.io/appium.io/docs/en/writing-running-appium/image-comparison/
for more details. For examples in Plasma there are
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1873 and
kcm_cursortheme_test.
    As usual, add a few tests for regressions.


ahiemstra
    I've mostly been busy with system monitor stuff, we did some work to
port to upstream tableview headers and use some other new features from
upstream
    one annoying thing is that keyboard navigation in tableview seems
rather broken which I think it's regressed between 6.5 and 6.6 :(


-- 
Méven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20231129/8cafd99e/attachment.htm>