D26032: feat: add Control API for auto rotation

Alexander Volkov noreply at phabricator.kde.org
Fri Oct 1 12:07:33 BST 2021


volkov added inline comments.

INLINE COMMENTS

> control.cpp:266
> +            const auto val = info[QStringLiteral("autorotate")];
> +            return !val.canConvert<bool>() || val.toBool();
> +        }

Why treat an inconvertible value as true and not false?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26032

To: romangg, #plasma
Cc: volkov, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20211001/4c105f49/attachment.htm>


More information about the Plasma-devel mailing list