Monday meeting notes for 22/3/2021

Mon Mar 22 12:03:45 GMT 2021

Alex
* Worked on improving the pre-commit hook, please review
https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/100.
* clang-format pre-commit hook
* Bugfixes regarding the KRunner history feature, third parties
override the RunCommand.qml and depend on methods that no longer
exist. This also means that for example Manjaro plasma ships per
default a really old variant of this file :/ Please review
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/723
* https://invent.kde.org/plasma/milou/-/merge_requests/25.
* And while at it I added autotest for the history functionality in
the KRunner framework,
https://invent.kde.org/frameworks/krunner/-/merge_requests/60
* Also worked on adding the prepare/teardown methods to the DBus
runners, https://invent.kde.org/frameworks/krunner/-/merge_requests/59.
This will help making the DBus runners "first class citizens"
https://invent.kde.org/frameworks/krunner/-/merge_requests/59. Of
course with an autotest ;)
* Also did some cleanup in the bookmarksrunner and added autotest for
the Firefox bookmarks reading and the conversion from the internal
bookmarks match to the KRunner QueryMatch (already merged, Harald
reviewed it).
* Also added more stuff to the de-duplication MR, please re-review
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/641
* Clang-format in Frameworks is still in progress, mostly some
tweaking/review of the already open MRs. Also the work for Plasma
continues with 5.21.3 being released
* Oh one more thing, d_ed could you please look into
https://bugs.kde.org/show_bug.cgi?id=433549, that has to do with some
DBus internaly I don't really know

Arjen
* I did a bunch of gwenview stuff
* I also spent some time on kquickcharts
* both to finish the new legend layout for system monitor and applets
* and to figure out the cause of rendering problems with charts on the pinephone
* that last one turns out to be due to the pinephone gpu
* basically it can only do 16-bit floating points
* and while that seems to be enough for rounded rectangles, lines need
some more calculations that apparently eat up the available precision
* I'm currently trying to see if I can find a workaround, but I may
have to deconstruct the shader a bit more to see if I can find out
where the actual precision loss happens
* but well, it basically summarizes to "the pinephone gpu is crap, we
knew that already, here's yet another reason why"

Justin
* I contributed my first "code" to KDE this week:
* Added a close button to Discover's screenshot popup -
https://invent.kde.org/plasma/discover/-/merge_requests/95
* Changed left/right buttons in Discover screenshot popup to be round
like the other buttons
https://invent.kde.org/plasma/discover/-/merge_requests/97

Carl
## Documentation
* Rewrote/Update window switcher:
https://invent.kde.org/documentation/develop-kde-org/-/merge_requests/86
(merged)
* Ported the kwin scriping tutorial:
https://invent.kde.org/documentation/develop-kde-org/-/commit/796f356b153e736a9af95093e3551171e710a2cb
* Ported the kwin api:
https://invent.kde.org/documentation/develop-kde-org/-/commit/79b01a02113019dae41fa852f8719811e2687fc9
* Simplified Plasma API components name:
https://invent.kde.org/frameworks/kapidox/commit/c41f1bb5250b6e48f9f5d03521c3f7636f98aca5
* Mark Plasma Style as internal (and don't display it in Plasma API
documentation) https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/220
(merged)
## Plasma
* Kirigamified the applet's config window:
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/289
(merged)
* Redesigned the Plasma Calendar:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/727
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/219
Also found out the calendar support in Plasma Framework is using GPL
instead of LGPL :(
## Plasma Mobile
Moved Koko and KQuickImageEditor to KDEReview

Vlad
not a lot to add since last week...
* fixed crashes introduced with the rework of wl_pointer, wl_touch,
and wl_seat interfaces
* started actually working on the input device grab thingy
* still waiting for code review on a bunch of my merge requests in
plasma/kwin and plasma/kwayland-server
* we receive a decent amount of wayland-related bug reports, which is
sort of a good sign, it indicates that more and more people try
wayland session
* the problem with most of those bug reports is that they are
intractable, e.g. missing debug symbols, truncated coredumps,
irreproducible description, etc
* we would highly appreciate any help with triaging such bug reports
[discussion about how to trigger those with obviously useless
coredumps, there will be a wiki page on how to deal] in general more
wayland triaging would be helpful

Nate
Done:
- Made Kickoff's section headers a bit more section headery
- Updated the placeholder messages throughout System Settings to use
the new "explanation:" property instead of duplicating buttons already
visible in the UI
- Fixed the "Navigation wraps around" setting in the Virtual Desktops
KCM not being respected when scrolling on the desktop to switch
virtual desktops
- Modernized the code of the Alternatives switcher and ported it
mostly away from PlasmaComponents2
- Added some missing metadata to the Breeze and Breeze Dark, and
Breeze Twilight theme definitions
Submitted and needs review:
- Set a default shortcut for Klipper's "Open Klipper at Mouse
Position" feature:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/726
- Improve System Monitor's software rendering fallback warning:
https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/109
- Use explanatory text instead of a button in Accounts KCM:
https://invent.kde.org/network/kaccounts-integration/-/merge_requests/23
Stuck and needs help from experienced people:
- Tried to make grid view KCMs always sort case insensitively, but got
stuck because adding KSortFilterProxyModels to the views made them get
out of sync with their models. Need help from someone more familiar
with this sort of thing (example:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/709)

Nico
* I mostly did some Qt6 prep in Frameworks
* And Breeze this time
* So I managed to run Qt6 Dolphin with Breeze
* Found a few bugs
* One in Qt that was promptly fixed by dfaure
* One in KWindowSystem that I reported
https://bugs.kde.org/show_bug.cgi?id=434557
    KDE bug 434557 in frameworks-kwindowsystem (general)
"KXMessages::broadcastMessageX triggers deprecated QByteArray
behavior" [normal,] https://bugs.kde.org/show_bug.cgi?id=434557
* Besides that I did some performance optimization in Ark so large
archives now load a bit faster
* Some fixes for KDE Connect
* And a bit of CMake cleanup in Plasma

Marco
# Plasma
* investigating https://bugs.kde.org/show_bug.cgi?id=360478 solving
problems wrt screen resolution change
* RFC patches of resolution-dependent layouts:
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/385
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/717
* more investigating wrt
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/696
and shipped when the real reason the patch was actually fixing things
was discovered :)
# System Settings
* investigating bug 429027
* still waiting final ship it:
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/348
https://invent.kde.org/plasma/systemsettings/-/merge_requests/59
https://bugs.kde.org/show_bug.cgi?id=434355
# Plasma Mobile
* started working on horizontal page flicking for the homescreen,
similar to android multi page homescreen
# Plasma Systemmonitor
* Merged https://invent.kde.org/plasma/libksysguard/-/merge_requests/138
* https://bugs.kde.org/show_bug.cgi?id=434355

-- 
Marco Martin