Monday meeting notes for 18/01/2021

[Marco Martin]

David R
- Finished the sddm kcm
- Working on improving startup time of plasma-systemonitor
- Temporary workaround for cyclic depdendecy for Units.qml (We can
just use Controls 1 to read the env variable...)
- Fixed the border of breeze QMenus being as good as invisible

Kai Uwe
Notifications:
* Show which app would open a file in job finished notification
    * Can anyone reproduce Nate's issue in
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/575
* Wrote KJobTracker for JobViewV2 stuff
    * fully async, batched, yada yada
    * API already shipped since Plasma 5.16 but not actually used by
Frameworks/KJob
* Worked on exposing quick reply in KNotification API
    * Please comment on the API proposal:
https://invent.kde.org/frameworks/knotifications/-/merge_requests/28
* Notifications "applications" page opens in a split column view
rather than as a new page. Fixes itself after resizing the window..
any idea, notmart?
plasma-browser-integration:
* Theres a crash on Wayland on teardown in libTaskManager, Bug 431633
KDE bug 431633 in plasma-browser-integration (Opera) "Sometimes
plasma-browser-integration crashes when I close Opera browser"
[crash,] https://bugs.kde.org/show_bug.cgi?id=431633
* Ported host to SPDX so I can then do the relicensing to
GPL-3.0-or-later, any comments?
https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/35
plasma-pa:
* Found that volume meters didn't work for recording *streams*, d_ed
courteously fixed it
Other:
* Fixed @3x icons in breeze-icons (folder name mismatch)
* Fixed "Folder is empty" label in Dolphin showing while folder was
still loading
* noticed SystemSettings crashes when run with QSG_VISUALIZE=overdraw,
probably some QQuickWidget issue
[Discussion about some kcms that now have 2 columns that shouldn't,
like notifications]

Alex
* Clang-format config is finished. Dfaure is also happy with the
config: https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/69#note_168957,
this is important for the frameworks.
* MRs reformat Plasma repos have already been made to some smaller
repos/repos with low traffic. (for example
https://invent.kde.org/plasma/sddm-kcm/-/merge_requests/4).
* I am not sure how to proceed with the bigger repos like
plasma-workspace or plasma-desktop. The final clang-format version is
in the to be released 5.79 frameworks. My idea would be that we wait
until 5.21.2, then there should not be that much traffic and
consequently merge conflicts on the stable branches. Or how do you
feel about making such a
* big code change right before the beta release?
[discussion about big code change fpor the reformat before or after
the beta. decision leaning towards before beta, while usuing new cmake
macros will be done after]

Carl
* Fixed a warning in Kirigami:
https://invent.kde.org/frameworks/kirigami/-/merge_requests/211
(merged)
* Experimented with the new inline reply in Knotification in NeoChat:
https://invent.kde.org/network/neochat/-/merge_requests/154. It's nice
thanks Kai :)

Nico
* Remove keepassxc icons from breeze as requested from upstream
https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/74
* Fix changing image format in spectacle:
https://invent.kde.org/graphics/spectacle/-/merge_requests/47
* Allow uploading files to gdrive via Purpose
https://invent.kde.org/network/kio-gdrive/-/merge_requests/12
* Redo nextcloud config UI in purpose
https://invent.kde.org/frameworks/purpose/-/merge_requests/25
* Use nextcloud icon for nextcloud in purpose
https://invent.kde.org/frameworks/purpose/-/merge_requests/23
* Fix showing calendar details when enabling plugins
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/566
* Simplify some cmake code
https://invent.kde.org/network/kaccounts-integration/-/merge_requests/21
* Cleanup cmake code and update requirements
https://invent.kde.org/network/kaccounts-integration/-/merge_requests/20
* VHI: Fix crash in screenlocker KCM
https://invent.kde.org/frameworks/kirigami/-/merge_requests/210
* VHI: Avoid applying user KCM changes when cacelling auth dialog
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/298
* Fix password sheet in user KCM
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/300
* Hide progressinfo when adding shortcut to desktop
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/303
* Some misc Qt6-related cleanup in Frameworks
* Some downstream issue chasing in Neon, Debian and Fedora

DavidE
* I fixed some misc bugs, most notable was Kirigami icons not using an atlas
bump about https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/5
 (startup ID handling)
* I hate X startup IDs so I know it's a horrible topic
* I also found something interesting and bad to be wary of If you
instantiate a KNewStuff.Dialog in QML it performs a network request
* I'll try and review that today
(https://invent.kde.org/plasma/khotkeys/-/merge_requests/3)

Arjen
* I did some basic profiling on plasma-systemmonitor at the start of
last week, which resulted in identifying several things we can improve
* I then spent the most of my week on a rework of the Kirigami
PlatformTheme internals so it shares data between different instances
rather than duplicating everything
* Other than that I fixed a memory leak in ksystemstats that would
happen in rare cases where NetworkManager goes haywire
https://invent.kde.org/plasma/ksysguard/-/merge_requests/61
* also a more generic note is that apparently QObject::connect can
lead to quite some memory usage especially when using lambdas
* i was disappointed on how much memory normal connects still take
* which resulted in me replacing a bunch of connects with more of a
listener pattern where I have an array of objects that want to be
notified of changes
* which has the advantage of only storing some data in the shared data object

Bhushan
* I had been working on some last minute fixes for KDE Pinephone images
* That said, would be lovely to get two patches in 5.21
* Layershell MR in kscreenlocker
https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/20
* Input method config option in kwin
https://invent.kde.org/plasma/kwin/-/merge_requests/591 (or at least
563)

Marco
# Plasma
* merged window moving patches, now dragging from empty areas should
work uniformly across qml, qwidgets and systemsettings qml kcms
# VHI bugs fixes
* BUG429235 kirigami sidebars such as discover having content under
header (is a bit workaroundy, ove the Qt bug
https://bugreports.qt.io/browse/QTBUG-90034)
* BUG428737 KCM headers not getting inactive titlebar color
* BUG417852 big date in vertical panels




-- 
Marco Martin