D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added inline comments.

INLINE COMMENTS

> broulik wrote in kcmaccess.cpp:141
> Are you sure this shouldn't be something like
> 
>   modifiers & (ScrollMask | LockMask | NumMask)

good catch.

> broulik wrote in kcmaccess.desktop:9
> What about this? We still need to autostart kaccess on login.
> Perhaps, while at it, you could port it over to proper autostart mechanism rather than abusing kcminit for that.

Can you elaborate on that? I don't really know what you mean.

> broulik wrote in kcmaccess.h:42
> Where is this being used?

It was used in the old code, I forgot to add in the Ui.

> broulik wrote in Bell.qml:89
> Why are you writing to a different property than you check for immutability?

changed the names on the kcfg file and forgot to update here. it's a bit annoying that part of the kconfig is string based and other part is proper code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200908/92505a32/attachment-0001.htm>