D29603: Adds custom spacing between task manager icons

[Jacopo Martellini]

martellini added a comment.


  In D29603#673942 <https://phabricator.kde.org/D29603#673942>, @ngraham wrote:
  
  > Thanks! And sorry for the long delay before reviewing. However this doesn't seem to be working for me; no matter what value I enter, my vertical icons-only-task manager's icon spacing does not change.
  >
  > Also, instead of allowing the user to specify a pixel value, what do you think about using more general terminology and a combobox? For example:
  >
  > - "Narrow" => 2px spacing
  > - "Medium" => 4px spacing
  > - "Wide" => 8 px spacing
  > - "Extra wide" => 12 px spacing
  >
  >   (numbers are totally random, just for example purposes)
  >
  >   What do you think?
  
  
  Hi, don't worry, I imagine this has been a busy period with 5.19 coming and the migration to Gitlab.
  Ok, I'm writing your idea, but with values from 0 to 24.
  Btw I think I've bumped into this: ComboBox.valueRole is not available <https://bugs.kde.org/show_bug.cgi?id=419521> 
  It should have been solved, but on neon with kde 5.18.5, kf 5.69, and qt 5.14.2 it still seems broken. Maybe I should see if upgrading solves the issue, but I'm skipping 5.70 because of that time units issue.
  I'll keep trying and let you know

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29603

To: martellini, #vdg, ngraham
Cc: ngraham, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200529/65dc44ee/attachment.htm>