D29807: Change Chrome API design

[Méven Car]

meven accepted this revision as: meven.
meven added a comment.
This revision is now accepted and ready to land.


  Two smalls things.
  
  Seems good to me otherwise.
  
  Give some times to other to have a final say before merging.

INLINE COMMENTS

> chromeprofile.cpp:33
> +    const QStringList profilesConfigKeys = localState.value(QStringLiteral("profile")).toMap()
> +        .value(QStringLiteral("info_cache")).toMap().keys();
> +    for (const QString &profile : profilesConfigKeys) {

Perhaps use an iterator instead of copying the keys.

> fetchsqlite.cpp:32
>  #include <sstream>
> +#include <QFileInfo>
>  

Is this used here ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200523/02042ad4/attachment.htm>