D29827: Give users the ability to disable the microphone indicator

[Méven Car]

meven added a comment.


  In D29827#673569 <https://phabricator.kde.org/D29827#673569>, @kurmikon wrote:
  
  > In D29827#673551 <https://phabricator.kde.org/D29827#673551>, @ngraham wrote:
  >
  > > The name needs to be your full name ("Firstname Lastname"). This was a pre-existing requirement, it's just now enforced before patch submission, rather than afterwards.
  >
  >
  > I was using the full name @ngraham, but it was rejecting the same. I will retry later, but this process shouldn't be simplified to new users? It's not stated inside the guide and it's useless enforce this requirement since the commit is done with an account where the full name is set in the profile.
  
  
  Did you `git commit --amend --author "FirstName LastName <email>"` ?
  You simply need to update the author in the commit itself.
  
  > Am I the only one experiencing this issue?
  
  Everybody would yes.
  Your problem was just your gitconfig had a pseudonym and kde git policy (for legal reasons) expect full names.
  
  Sorry it seems our documentation is not very clear about this fact currently.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: meven, bcooksley, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200523/65b07a95/attachment-0001.htm>