D29807: Change Chrome API design
Méven Car
noreply at phabricator.kde.org
Fri May 22 17:56:08 BST 2020
meven added a comment.
Seems good, two small clean ups
INLINE COMMENTS
> chromeprofile.cpp:8
> +ProfileBookmarks::ProfileBookmarks(const QString &path, const QString &name)
> + : m_path(path), m_name(name), m_favicon(nullptr) {
> + // Remove "Bookmarks" from end of path
`{` on new line
> chromeprofile.cpp:27
> + if(jdoc.isNull()) {
> + qDebug() << "error opening " << QFileInfo(localStateFile).absoluteFilePath();
> + return profiles;
Remove
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29807
To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200522/9b677c05/attachment-0001.htm>
More information about the Plasma-devel
mailing list