D29268: [WIP] Add Date/Time dialog

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> broulik wrote in CMakeLists.txt:69
> Why this only on Android? or is that used for that dummy library?

It's for the dummy library only

> broulik wrote in FindGradle.cmake:2
> Feels like this should go into ECM?

Yep

> broulik wrote in DateDialog.qml:12
> `org.kde.kirigamiaddons.private.dateandtime` to emphasis it's an impl detail

I'd rather do that in a separate patch since it should also be done for other classes

> broulik wrote in TimeDialog.qml:15
> Generally conversions between C++ timedate and JavaScript `Date` is bad. There's no way to represent just a time with no date and timezone associated with it in JavaScript.
> While it's ugly, I'd suggest we return a bunch of `int`.
> Also, I think we should have the selected time as properties and an `accepted`/rejected signal or similar.
> (Same probably goes for the date picker)

In this particular case the timezone is not relevant though

REPOSITORY
  R1047 Kirigami Addons

REVISION DETAIL
  https://phabricator.kde.org/D29268

To: nicolasfella, davidedmundson, vkrause, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200518/f7de2410/attachment-0001.htm>