D29784: Hardcode less colorSets

Nathaniel Graham noreply at phabricator.kde.org
Fri May 15 18:01:04 BST 2020


ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Now the tiny toolbar above the sidebar is a different color from the one beside it: F8323489: Screenshot_20200515_105617.png <https://phabricator.kde.org/F8323489>
  
  It's appropriate for the views to have the view background color (off-white), but the toolbar is supposed to use the window background color (gray-ish), not the view background color. Why isn't that working?

INLINE COMMENTS

> SourcesPage.qml:27
>  
> +            Kirigami.Theme.colorSet: Kirigami.Theme.View
> +            Kirigami.Theme.inherit: false

These should not be needed at all

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D29784

To: apol, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200515/a3451d09/attachment.htm>


More information about the Plasma-devel mailing list