D29694: Introduce Avatar component

Carson Black noreply at phabricator.kde.org
Fri May 15 16:19:56 BST 2020


cblack added inline comments.

INLINE COMMENTS

> mart wrote in kirigamiplugin.cpp:259
> I don't like this, as even tough is called "private" is really public api as there isn't really any way to make a c++ type not accessible.
> nothing in that c++ class seems really to be necessary to be c++

the string manipulation used for generating initials isn't particularly feasible to do in javascript; especially the stuff that prods QChars

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29694

To: cblack, #kirigami, #vdg, mart
Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200515/0b3a15e5/attachment.htm>


More information about the Plasma-devel mailing list