D29687: [IconApplet] Port KRun to ApplicationLauncherJob

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> broulik wrote in iconapplet.cpp:435
> but "desktop file path" is what we're doing. what I believe is happening that you're actually launching the original file, not the one the icon uses.

I tried with:

  KService::Ptr service = KService::serviceByStorageId(m_localPath);
  qDebug() << "entryPath" << service->entryPath();
  KIO::ApplicationLauncherJob *job = new KIO::ApplicationLauncherJob(service);

and got:
entryPath "/home/ahmad/.local/share/plasma_icons/org.kde.dolphin.desktop"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200515/53690444/attachment.htm>