D29726: BookmarksRunner: Change caching databases

Alexander Lohnau noreply at phabricator.kde.org
Fri May 15 15:29:13 BST 2020


alex added inline comments.

INLINE COMMENTS

> meven wrote in chrome.cpp:55
> Might as well check the returned value for error

If this fails only the icons are affected and the default icon will be displayed, this case will be handled in the FetchSqlite class

> meven wrote in fetchsqlite.cpp:42
> Can be removed as well

I would rather do that in another patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29726

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200515/29ef7e05/attachment.htm>


More information about the Plasma-devel mailing list