D29771: [Notifications] Don't take updated time into account for sorting
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri May 15 09:37:32 BST 2020
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Notification spec says, when replacing a notification:
> The server must atomically (ie with no flicker or other visual cues) replace the given notification with this one.
Notifications shifting about is a "visual cue".
TEST PLAN
I've noticed that with D29770 <https://phabricator.kde.org/D29770> where I always update notification text, notification can randomly swap places depending on which free space job happened to be finished first.
Since this is a "fix to make it more spec compliant", could go into 5.18? Definitely should go into 5.19
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29771
AFFECTED FILES
libnotificationmanager/notificationsortproxymodel.cpp
To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200515/c684488c/attachment.htm>
More information about the Plasma-devel
mailing list