D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since Inkscape is finally moved to GTK3, it's time to start GTK2
  deprecation process.
  
  What this does is just a hiding GUI for setting GTK2 themes.
  Despite of that, GTK2 will be set implicitly along with the GTK3 theme.
  
  Some FAQ:
  Q: What if there is no GTK2 theme with the name of GTK2 one?
  A: Chances of that is close to zero. Most, if not all, GTK3 themes
  contain gtk-2.0 folder along with gtk-3.0 one. Even if there is such
  a theme, currently it also will not work. That's because of xsettingsd,
  that overrides GTK2 configuration file.
  
  Q: What about Breeze Dark GTK2 theme for GIMP?
  A: GIMP has a dark theme inside. Breeze-dark will not work for the same
  reason as the above - xsettingsd with only one theme for GTK2 and GTK3.
  
  GUI changes: now there only one option for GHNS and only one combo for themes,
  title for GHNS has changed

TEST PLAN
  1. Apply D29748 <https://phabricator.kde.org/D29748> and this patch
  2. Restart Kded5
  3. Open Application Style KCM > GTK Style
  4. Change GTK Theme, check if both GTK2 and GTK3 apps have the same theme
  5. Check Get New... is working

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hide-gtk2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29749

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/gtk2_themes.knsrc
  kcms/style/gtk3_themes.knsrc
  kcms/style/gtk_themes.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/package/contents/ui/GtkStylePage.qml

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200514/578e2296/attachment-0001.htm>