D29692: Recommend better width calculation for PlaceholderMessage
Nathaniel Graham
noreply at phabricator.kde.org
Tue May 12 20:25:20 BST 2020
ngraham created this revision.
ngraham added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Left and right anchors + margins + vertical centering don't work well work together, and
the text overflows instead of wrapping. Setting the vertical anchor and defining a width
works much better. Also recommend larger margins by default as this looks nicer.
I don't want to define a default width and alignment in the component itself that uses
anchors and references `parent`, since it may be inside a layout rather than being the
child of a ListView or something.
TEST PLAN
Literally none, it's a documentation improvement. The recommended code works thoigh.
REPOSITORY
R169 Kirigami
BRANCH
recommend-better-PlaceholderMessagewidth (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29692
AFFECTED FILES
src/controls/PlaceholderMessage.qml
To: ngraham, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200512/7df25c45/attachment-0001.htm>
More information about the Plasma-devel
mailing list