D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging
Nathaniel Graham
noreply at phabricator.kde.org
Mon May 11 16:01:22 BST 2020
ngraham created this revision.
ngraham added reviewers: broulik, Plasma, Localization.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Current code only updates the text on the "not charging" condition, causing the tooltip
display to get out of sync with the rest of the applet once charging begins. This patch
fixes that.
This is a bugfix for a bug that affects Plasma 5.18, but fixing it requires introducing a
new string. As such, I am targeting 5.19, but if the #Localization <https://phabricator.kde.org/tag/localization/> team approves, I can
land this on the stable branch if it's accepted.
BUG: 20920
FIXED-IN: 5.19.0
TEST PLAN
F8309775: tooltip updates now.png <https://phabricator.kde.org/F8309775>
REPOSITORY
R120 Plasma Workspace
BRANCH
fix-non-updating-battery-tooltip (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29636
AFFECTED FILES
applets/batterymonitor/package/contents/ui/batterymonitor.qml
To: ngraham, broulik, #plasma, #localization
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200511/f6e6a557/attachment.htm>
More information about the Plasma-devel
mailing list