D29633: [Battery Monitor] Fix toolTipMainText when plugged in

Kai Uwe Broulik noreply at phabricator.kde.org
Mon May 11 14:38:51 BST 2020


broulik created this revision.
broulik added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It only had a return value for "NoCharge" since the else case was only for not plugged in, resulting in it effectively returning `undefined`, throwing during assignment "cannot assign [undefined] to string" and leaving whatever text happened to be shown last.

TEST PLAN
  Literally none

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29633

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: broulik, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200511/379a07c1/attachment.htm>


More information about the Plasma-devel mailing list