D26111: Runner: make recentdocument use KActivityStats data

Méven Car noreply at phabricator.kde.org
Sat May 9 06:54:18 BST 2020


meven marked 2 inline comments as done.
meven added a comment.


  I need to change dev machine, now that plasma-workspace needs Qt5.14, that explains the delay.

INLINE COMMENTS

> broulik wrote in recentdocuments.cpp:78
> Do we really want `QUrl::fromUserInput` here? This thing typically assumes web addresses. Maybe pass `AssumeLocalFile`? But I recal that doing a file system access every time checking for existance.. probably not a big deal in this instance since it's in a thread

It is needed for QString coming from KActivitiesStats, they can be "/home/meven/doc.txt" or "file://" or "application://" or "http://".
So QUrl::fromEncoded or QUrl::fromLocalFile can't be used.
AssumeLocalFile would be nice to use, but it requires to provide a working directory. https://doc.qt.io/qt-5/qurl.html#fromUserInput-1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26111_1

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: alex, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200509/9adb1e1d/attachment.htm>


More information about the Plasma-devel mailing list